Skip to content

feat(plugin): let a pillar add optional entries to another pillar's tag - #39

Merged
adamico merged 7 commits into
mainfrom
fix/plays-alone-wickedness
Oct 27, 2026
Merged

adamico merged 7 commits into
mainfrom
fix/plays-alone-wickedness

Conversation

@adamico

@adamico adamico commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

This PR brings checkPlaysAlone in line with two A Touch Of decisions: Cold is shelved in favour of Tough As Nails (5thlayer/atouchof#5), and Wickedness joins as a Pillar that adds entries to Madness's tags (5thlayer/atouchof#6). ADR 0014 records the second decision.

  • Pillar list. A Touch Of's Pillars are now atouchofdarkness, atouchofmadness and atouchofwickedness. atouchofcold moves to the suite's retired list, the way factoryworks is retired, so no Pillar or FactoryWorks Module may name it while it's shelved. If Cold comes back, a patch release moves it back into the list.

  • Optional tag entries. A Touch Of ADR-0002, as amended by atouchof#6, lets one Pillar add entries to another Pillar's tag. A Pillar may now ship files under another Pillar's data/<ns>/tags/ if each file:

    • has replace absent or false,
    • has no NeoForge remove list,
    • has only entries of the form {"id": "<its own id or #tag>", "required": false}.

    Every other file in that namespace is reported, with the reason: a bare or required entry, replace: true, a remove list, an id that isn't its own, or a file that isn't a tag. The exception does not cover assets/<ns>, the Runtime, the retired atouchofcold, another suite's namespace, or FactoryWorks, which has no such exception. The first use is Wickedness's data/atouchofmadness/tags/entity_type/unsettling.json, which adds the Bailiff.

  • ADR 0013 gets an amendment. docs/plugin.md and the CHANGELOG are updated.

The plugin releases as 0.4.5, a patch, because no Module has to edit its build (ADR 0001). As with #37, the release commit, publish and tag are made on main after merge and are not part of this PR.

Written test-first in PlaysAloneTest and ModulePluginTest, and reviewed with the code-review skill. Its one real finding, the remove list, is fixed in the second commit. All 60 plugin tests pass locally, as do the template's checkPlaysAlone and reuse lint.

🤖 Generated with Claude Code

adamico and others added 7 commits October 27, 2026 12:57
A Touch Of's Pillars are now atouchofdarkness, atouchofmadness and
atouchofwickedness. atouchofcold is shelved in favour of Tough As Nails, and
retired, so none may name it (5thlayer/atouchof#5, #6).

checkPlaysAlone lets a Pillar ship data/<other pillar>/tags/** files whose
replace is absent or false and whose every entry is an optional entry naming
one of its own ids, as A Touch Of ADR-0002 now allows. Any other file under
that namespace still fails, and the failure says why. FactoryWorks gets no
such exception. ADR 0014 records the decision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NeoForge reads a tag file's remove list, so a pillar could take entries out
of another pillar's tag and still pass. checkPlaysAlone now reports it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
namespaces() reports forbidden folders again, and otherTags() reads the
tags a pillar may add to. A file directly under tags/, outside any registry
folder, is not a tag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A file outside tags/ now names that, an empty remove list fails as any
remove does, and a test pins that the runtime takes no exception.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tag-file checks move to OptionalTagFile, and each suite names what a
module may ship in another module's tags. Invalid JSON, a replace that is
not a boolean, a remove with no values and an entry with no id each say so,
and an optional entry of another pillar's id is reported once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An id with no namespace names minecraft:<id>, so it is no longer taken
as the pillar's own. A missing or non-string id is reported as such
before the required check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamico
adamico merged commit 445fa64 into main Oct 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant